[next] telepathy-glib: Do domain-specific errors via GDBus, not dbus-glib

Simon McVittie smcv at kemper.freedesktop.org
Thu Mar 27 08:42:04 PDT 2014


Module: telepathy-glib
Branch: next
Commit: 7ee8429d49a8b625b3fa8c41a0a9f47e8c547d00
URL:    http://cgit.freedesktop.org/telepathy/telepathy-glib/commit/?id=7ee8429d49a8b625b3fa8c41a0a9f47e8c547d00

Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date:   Tue Mar 11 18:04:06 2014 +0000

Do domain-specific errors via GDBus, not dbus-glib

We can get rid of TP_DBUS_ERROR_UNKNOWN_REMOTE_ERROR, because
G_IO_ERROR_DBUS_ERROR doesn't have the same weird abuse of GError
semantics that DBUS_GERROR_REMOTE_EXCEPTION did.

I moved TP_DBUS_ERROR_INCONSISTENT from last to 0'th TP_DBUS_ERROR,
to avoid having to renumber all of them.

We can probably get rid of a lot of these errors in favour of
G_IO_ERROR or G_DBUS_ERROR members, but for now, let's keep them.

---

 .../telepathy-glib/telepathy-glib-sections.txt     |    1 -
 telepathy-glib/channel-group.c                     |   16 +-
 telepathy-glib/connection.c                        |    6 +-
 telepathy-glib/errors.c                            |   30 +++-
 telepathy-glib/proxy-internal.h                    |    3 -
 telepathy-glib/proxy.c                             |  170 +++-----------------
 telepathy-glib/proxy.h                             |    5 +-
 tests/dbus/connection-error.c                      |   51 +-----
 tests/suppressions/tpl.supp                        |    8 -
 tools/telepathy-glib.supp                          |    8 -
 10 files changed, 67 insertions(+), 231 deletions(-)

Diff:   http://cgit.freedesktop.org/telepathy/telepathy-glib/diff/?id=7ee8429d49a8b625b3fa8c41a0a9f47e8c547d00


More information about the telepathy-commits mailing list