[next] telepathy-salut: Simplify srcdir/builddir location

Simon McVittie smcv at kemper.freedesktop.org
Mon May 12 03:56:46 PDT 2014


Module: telepathy-salut
Branch: next
Commit: fcc0e33f3a03c045356e04839b09368c996842b4
URL:    http://cgit.freedesktop.org/telepathy/telepathy-salut/commit/?id=fcc0e33f3a03c045356e04839b09368c996842b4

Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date:   Mon May 12 10:30:14 2014 +0100

Simplify srcdir/builddir location

---

 tests/twisted/Makefile.am    |    6 +++---
 tests/twisted/run-test.sh.in |   33 ++++++++++++++++-----------------
 2 files changed, 19 insertions(+), 20 deletions(-)

diff --git a/tests/twisted/Makefile.am b/tests/twisted/Makefile.am
index 682e79b..d764afe 100644
--- a/tests/twisted/Makefile.am
+++ b/tests/twisted/Makefile.am
@@ -74,8 +74,8 @@ check-twisted: $(BUILT_SOURCES)
 		salut_test_sleep=--sleep=$(CHECK_TWISTED_SLEEP); \
 	fi; \
 	CHECK_TWISTED_UNINSTALLED=1 \
-	  SALUT_ABS_TOP_SRCDIR=@abs_top_srcdir@ \
-	  SALUT_ABS_TOP_BUILDDIR=@abs_top_builddir@ \
+	  G_TEST_SRCDIR=@abs_srcdir@ \
+	  G_TEST_BUILDDIR=@abs_builddir@ \
 	  CHECK_TWISTED_SLEEP=$$salut_test_sleep \
 	  ./run-test.sh "$(TWISTED_TESTS)"
 
@@ -110,7 +110,7 @@ endif
 
 run-test.sh: run-test.sh.in Makefile
 	$(AM_V_GEN)sed \
-			-e 's![@]saluttestsdir[@]!${testsdir}!' \
+			-e 's![@]twistedtestsdir[@]!${twistedtestsdir}!' \
 			-e 's![@]TEST_PYTHON[@]!$(TEST_PYTHON)!' \
 			< $< > $@.tmp && \
 		chmod +x $@.tmp && \
diff --git a/tests/twisted/run-test.sh.in b/tests/twisted/run-test.sh.in
index f3ca734..e617f63 100644
--- a/tests/twisted/run-test.sh.in
+++ b/tests/twisted/run-test.sh.in
@@ -1,40 +1,39 @@
 #!/bin/sh
 
 if test "x$CHECK_TWISTED_UNINSTALLED" = x; then
-  script_fullname=`readlink -e "@saluttestsdir@/twisted/run-test.sh"`
+  script_fullname=`readlink -e "@twistedtestsdir@/run-test.sh"`
   if [ `readlink -e "$0"` != "$script_fullname" ] ; then
     echo "This script is meant to be installed at $script_fullname" >&2
     exit 1
   fi
 
-  test_src="@saluttestsdir@"
-  test_build="@saluttestsdir@"
-  config_file="@saluttestsdir@/twisted/tools/servicedir/tmp-session-bus.conf"
+  G_TEST_SRCDIR="@twistedtestsdir@"
+  export G_TEST_SRCDIR
+  G_TEST_BUILDDIR="@twistedtestsdir@"
+  export G_TEST_BUILDDIR
 
-  PYTHONPATH="@saluttestsdir@/twisted"
+  PYTHONPATH="${G_TEST_SRCDIR}"
   export PYTHONPATH
 else
-  if test -z "$SALUT_ABS_TOP_SRCDIR"; then
-    echo "SALUT_ABS_TOP_SRCDIR must be set" >&2
+  if ! test -d "$G_TEST_SRCDIR"; then
+    echo "G_TEST_SRCDIR must be set" >&2
     exit 1
   fi
-  if test -z "$SALUT_ABS_TOP_BUILDDIR"; then
-    echo "SALUT_ABS_TOP_BUILDDIR must be set" >&2
+  if ! test -d "$G_TEST_BUILDDIR"; then
+    echo "G_TEST_BUILDDIR must be set" >&2
     exit 1
   fi
 
-  test_src="${SALUT_ABS_TOP_SRCDIR}/tests"
-  test_build="${SALUT_ABS_TOP_BUILDDIR}/tests"
-  config_file="${test_build}/twisted/tools/tmp-session-bus.conf"
-
-  PYTHONPATH="${test_src}/twisted:${test_build}/twisted"
+  PYTHONPATH="${G_TEST_SRCDIR}:${G_TEST_BUILDDIR}"
   export PYTHONPATH
 fi
 
+config_file="${G_TEST_BUILDDIR}/tools/tmp-session-bus.conf"
+
 if [ -n "$1" ] ; then
   list="$1"
 else
-  list=$(cat "${test_build}"/twisted/twisted-tests.list)
+  list=$(cat "${G_TEST_BUILDDIR}"/twisted-tests.list)
 fi
 
 if [ -z "$SALUT_TEST_REAL_AVAHI" ]; then
@@ -44,12 +43,12 @@ fi
 any_failed=0
 for i in $list ; do
   echo "Testing $i ..."
-  sh "${test_src}/twisted/tools/with-session-bus.sh" \
+  sh "${G_TEST_SRCDIR}/tools/with-session-bus.sh" \
     ${CHECK_TWISTED_SLEEP} \
     --config-file="${config_file}" \
     ${also_for_system} \
     -- \
-    @TEST_PYTHON@ -u "${test_src}/twisted/$i"
+    @TEST_PYTHON@ -u "${G_TEST_SRCDIR}/$i"
   e=$?
   case "$e" in
     (0)



More information about the telepathy-commits mailing list