telepathy-qt: BaseConnection: Added DBus ReleaseHandles() method.

Alexandr Akulich kaffeine at kemper.freedesktop.org
Wed May 6 01:10:28 PDT 2015


Module: telepathy-qt
Branch: master
Commit: 9b80bf8d383a5cbe768b6956b5937c4ef446cfae
URL:    http://cgit.freedesktop.org/telepathy/telepathy-qt/commit/?id=9b80bf8d383a5cbe768b6956b5937c4ef446cfae

Author: Alexandr Akulich <akulichalexander at gmail.com>
Date:   Tue Apr 21 13:05:01 2015 +0500

BaseConnection: Added DBus ReleaseHandles() method.

Since 0.21.6, this method does nothing and returns successfully.

Reviewed-by: David Edmundson

---

 TelepathyQt/base-connection-internal.h |    4 ++--
 TelepathyQt/base-connection.cpp        |    9 +++++++++
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/TelepathyQt/base-connection-internal.h b/TelepathyQt/base-connection-internal.h
index 67814ff..f8e109c 100644
--- a/TelepathyQt/base-connection-internal.h
+++ b/TelepathyQt/base-connection-internal.h
@@ -67,10 +67,10 @@ private Q_SLOTS:
     void listChannels(
             const Tp::Service::ConnectionAdaptor::ListChannelsContextPtr &context);
 
-    //void releaseHandles(uint handleType, const Tp::UIntList &handles, const Tp::Service::ConnectionAdaptor::ReleaseHandlesContextPtr &context);
     void requestChannel(const QString &type, uint handleType, uint handle, bool suppressHandler,
                         const Tp::Service::ConnectionAdaptor::RequestChannelContextPtr &context);
-
+    void releaseHandles(uint handleType, const Tp::UIntList &handles,
+            const Tp::Service::ConnectionAdaptor::ReleaseHandlesContextPtr &context);
     void requestHandles(uint handleType, const QStringList &identifiers,
             const Tp::Service::ConnectionAdaptor::RequestHandlesContextPtr &context);
 
diff --git a/TelepathyQt/base-connection.cpp b/TelepathyQt/base-connection.cpp
index 6070f4c..2bed0e5 100644
--- a/TelepathyQt/base-connection.cpp
+++ b/TelepathyQt/base-connection.cpp
@@ -148,6 +148,7 @@ void BaseConnection::Adaptee::getStatus(const Tp::Service::ConnectionAdaptor::Ge
 
 void BaseConnection::Adaptee::holdHandles(uint handleType, const UIntList &handles, const Service::ConnectionAdaptor::HoldHandlesContextPtr &context)
 {
+    // This method no does anything since 0.21.6
     Q_UNUSED(handleType)
     Q_UNUSED(handles)
     context->setFinished();
@@ -191,6 +192,14 @@ void BaseConnection::Adaptee::requestChannel(const QString &type, uint handleTyp
     context->setFinished(QDBusObjectPath(channel->objectPath()));
 }
 
+void BaseConnection::Adaptee::releaseHandles(uint handleType, const UIntList &handles, const Service::ConnectionAdaptor::ReleaseHandlesContextPtr &context)
+{
+    // This method no does anything since 0.21.6
+    Q_UNUSED(handleType)
+    Q_UNUSED(handles)
+    context->setFinished();
+}
+
 void BaseConnection::Adaptee::requestHandles(uint handleType, const QStringList &identifiers,
         const Tp::Service::ConnectionAdaptor::RequestHandlesContextPtr &context)
 {



More information about the telepathy-commits mailing list