telepathy-qt: CMake: Properly set visibility for the linked libraries

[Alexandr Akulich]

Module: telepathy-qt
Branch: master
Commit: 8d129b4d973498c97456192135c8cddf17b17ee5
URL:    http://cgit.freedesktop.org/telepathy/telepathy-qt/commit/?id=8d129b4d973498c97456192135c8cddf17b17ee5

Author: Alexander Akulich <akulichalexander at gmail.com>
Date:   Thu Nov  7 02:25:11 2019 +0300

CMake: Properly set visibility for the linked libraries

---

 TelepathyQt/CMakeLists.txt | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/TelepathyQt/CMakeLists.txt b/TelepathyQt/CMakeLists.txt
index f79d3d6c..4a0fe38c 100644
--- a/TelepathyQt/CMakeLists.txt
+++ b/TelepathyQt/CMakeLists.txt
@@ -769,32 +769,35 @@ foreach(moc_src ${telepathy_qt_MOC_SRCS})
 endforeach()
 
 # Link
-target_link_libraries(telepathy-qt${QT_VERSION_MAJOR} # PUBLIC
+target_link_libraries(telepathy-qt${QT_VERSION_MAJOR} PUBLIC
     Qt5::Core
     Qt5::DBus
     Qt5::Network
+)
+
+target_link_libraries(telepathy-qt${QT_VERSION_MAJOR} PRIVATE
     Qt5::Xml
 )
 
-target_link_libraries(telepathy-qt${QT_VERSION_MAJOR}
+target_link_libraries(telepathy-qt${QT_VERSION_MAJOR} PUBLIC
     ${TP_QT_LIBRARY_LINKER_FLAGS})
 
 target_include_directories(telepathy-qt${QT_VERSION_MAJOR} PUBLIC "$<INSTALL_INTERFACE:${INCLUDE_INSTALL_DIR}/telepathy-qt${QT_VERSION_MAJOR}/>")
 
 # Link - Library used by tests to test some unexported functionality
-target_link_libraries(telepathy-qt-test-backdoors # PUBLIC
+target_link_libraries(telepathy-qt-test-backdoors PUBLIC
     Qt5::Core
     Qt5::DBus
     Qt5::Network
     Qt5::Xml
 )
 
-target_link_libraries(telepathy-qt-test-backdoors
+target_link_libraries(telepathy-qt-test-backdoors PUBLIC
     ${TP_QT_LIBRARY_LINKER_FLAGS})
 
 if (ENABLE_COMPILER_COVERAGE)
-    target_link_libraries(telepathy-qt${QT_VERSION_MAJOR} gcov)
-    target_link_libraries(telepathy-qt-test-backdoors gcov)
+    target_link_libraries(telepathy-qt${QT_VERSION_MAJOR} PRIVATE gcov)
+    target_link_libraries(telepathy-qt-test-backdoors PRIVATE gcov)
 endif ()
 
 # Set the correct version number
@@ -981,11 +984,10 @@ if(ENABLE_SERVICE_SUPPORT)
     endforeach()
 
     # Link
-    target_link_libraries(telepathy-qt${QT_VERSION_MAJOR}-service
+    target_link_libraries(telepathy-qt${QT_VERSION_MAJOR}-service PUBLIC
         Qt5::Core
         Qt5::DBus
-        telepathy-qt${QT_VERSION_MAJOR}
-        ${TP_QT_LIBRARY_LINKER_FLAGS})
+        telepathy-qt${QT_VERSION_MAJOR})
 
     # Set the correct version number
     set_target_properties(telepathy-qt${QT_VERSION_MAJOR}-service PROPERTIES