[Telepathy] [Bug 11688] [Patch] support of xep-0012, last activity

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Aug 30 03:06:48 PDT 2007


------- Comment #3 from guillaume.desmottes at collabora.co.uk  2007-08-30 03:06 PST -------
Shouldn't we use time_t instead of gdouble ?

connection_iq_last_cb: please check lm_message_node_get_attribute (iq, "from")

+  g_free( seconds);  ->  g_free (seconds);

According latest coding style, when you write a function call on multi lines,
args have to be 4 spaces alligned.

Except that, patch looks good to me.

Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the Telepathy mailing list