[Telepathy] Review: telepathy-spec-stream

Simon McVittie simon.mcvittie at collabora.co.uk
Fri Jun 1 09:31:49 PDT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Some comments on http://projects.collabora.co.uk/~monkey/telepathy-spec-stream/:

* When documenting <tp:enumvalue suffix="Stream_Unix",

  * it should be <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
    and contain some <p> tags for paragraphing

  * "traffic through Unix socket" -> "traffic through a Unix stream socket"

  * "the connection managers exports" -> "the connection manager exports"
    (and start a new paragraph)

  * "these pair of sockets" -> "this pair of sockets"

* When documenting OfferDBusTube,

  * in parameters, "A dicionary of properties" -> "A dictionary of
    service-specific parameters"

  * In NotImplemented, "Connection Manager doesn't" -> "The connection manager
    doesn't"

* OfferStreamUnixTube:

  * give the docstring xmlns="http://www.w3.org/1999/xhtml" and use
    <a href="http://www.dns-sd.org/ServiceTypes.html">http://www.dns-sd.org/ServiceTypes.html</a>

  * we still haven't reached a conclusion about the type of the "socket"
    parameter? I think it should be 'ay' rather than 's'; ditto for
    GetStreamUnixSocketAddress
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: OpenPGP key: http://www.pseudorandom.co.uk/2003/contact/ or pgp.net

iD8DBQFGYEn1WSc8zVUw7HYRAmBCAJ0UJs99eTCBY4yrOAOhwejkg0rn0QCeL+Du
DRglSI9bI/rRqI7D/ncfXo8=
=chCG
-----END PGP SIGNATURE-----


More information about the Telepathy mailing list