[Telepathy] [Bug 11291] support for xep-0092, Software Version

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sun Jun 17 04:38:16 PDT 2007


------- Comment #2 from dafydd.harries at collabora.co.uk  2007-06-17 04:37 PST -------
Patch looks good, but perhaps the code would be more readable if it used our
lm_message_build utility function.


+  if (!lm_connection_send (self->lmconn, result, NULL))
+  {
+      DEBUG ("sending disco response failed");
+  }

Brackets should be indented two more spaces.

I would prefer it if there were blank lines around compound statements.

Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the Telepathy mailing list