[Telepathy] Proposal for changes on tp-qt4

Olli Salli ollisal at gmail.com
Fri Dec 12 12:30:42 PST 2008

On Wed, Dec 10, 2008 at 2:37 PM, Andre Moreira Magalhaes
<andre.magalhaes at collabora.co.uk> wrote:
> Hi all,
> So after taking a look at the tp-qt4 code and structure I came up with
> some ideas that IMHO could be improvements. Those are basically
> structural changes, so here is a list of changes I would like to make:
> ...
> So please let me know what do you think about these changes. If you
> agree I can do them and send to review. I would suggest doing that now
> that we don't have too much code, so it wouldn't be a really big change :)

I agree with Simon, please, let's get the outstanding branches to
ideally zero before attempting anything like this. The trouble it
causes is not a function of the amount of code in existence - a mv
cli-* .. is just as easy to do if that expands to 10 files than if
that expands to 5, and most often adding new functionality doesn't
even mean adding new files, but adding stuff to existing ones!
However, as Simon mentioned, such an invasive change will break all
branches based on the old structure causing a rather annoying need for
an almost-by-hand-rebase merge.

> BR
> Andrunko

Olli Salli

More information about the Telepathy mailing list