[Telepathy] Inspectotron review

[Travis Reitter]

Hi Sjoerd,

I checked out your inspectotron implementation branches:

http://monkey.collabora.co.uk/telepathy-gabble-sjoerd-inspectotron
http://monkey.collabora.co.uk/telepathy-glib-sjoerd-inspectotron
http://monkey.collabora.co.uk/telepathy-inspector-sjoerd-inspectotron 

My code comments follow, though they're basically all trivial. I'm not
terribly familiar with tp-glib mixins or D-Bus properties, so I kind of
glossed over fine details, but the code looks generally good.

I also tried out the code in conjunction with Empathy 0.23.4. I had to
bump the tp-glib version to 0.7.13.1 for the inspector, but it seemed to
still work fine.

In inspector, I got my contacts' info within the Presence tab as
expected. (I didn't carefully compare every value with Empathy's
results, but it seemed fine).

-Travis

=====================

tp-glib

* contacts-mixin.c
   * tp_base_connection_get_contact_attributes()
      * seems like this should be named something more like
tp_base_connection_init_contact_attributes() -- I usually expect getter
functions to be non-void :)
   * tp_contacts_mixin_finalize()
      * s/dissappear/disappear/
   * tp_contacts_mixin_iface_init()
      * re-flow header comment beginning "Fill in the vtable..."
   * tp_contacts_set_contact_attribute()
      * s/contacts attribute hash for as passed to/contacts attribute
hash as passed to/

tp-gabble

* conn-aliasing.c
   * aliases_request_cache_pep()
      * s/successfull/successful/

tp-inspector

* looks like autogen.sh isn't part of the source distribution