[Telepathy] [Bug 15198] Crash when joining chatroom

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=15198





--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2008-03-25 06:37:05 PST ---
The handle is probably one that exists in the backlog, but is not in the
chatroom any more, so it's only ref'd while it's in the pending messages list.
Another part in the ongoing handle-validity nightmare...

The following sequence of calls by Empathy would work correctly (the only
failure case I can think of is someone else is acknowledging the messages too):

* get the Received signal, or ListPendingMessages
* hold the handle with HoldHandles
* *only then* acknowledge the message

Gabble should not be using either assert or return_if_fail for this sort of
thing - return_if_fail is an assertion too, and it's inappropriate to assert
about anything received from outside the process. It should just be returning
the InvalidHandle error, like it did to produce the various lines tagged
"TpContact" in your log.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.