[Telepathy] [Bug 19367] time_t is assumed to be always 32bit in text-mixin

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=19367


Sunil Mohan Adapa <sunil at synovel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|telepathy at lists.freedesktop.|sunil at synovel.com
                   |org                         |
             Status|NEW                         |ASSIGNED




--- Comment #4 from Sunil Mohan Adapa <sunil at synovel.com>  2009-01-08 01:50:38 PST ---
Created an attachment (id=21797)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=21797)
Alternative patch

(In reply to comment #3)
> Aha! OK, the bug is actually that we assume time_t to be the same size as guint
> (which may or may not be 32 bits - dbus-glib uses guint for type 'u' even if
> guint is actually larger than that).

I understand now. Only dbus insists that 'u' be 32bits and dbus-glib will take
guint for 'u' which could of any length.

> 
> Suggested patch:
[...]
> -          1, msg->timestamp,
> +          1, (guint) msg->timestamp,

It seems to me that s/time_t/guint/ is nicer. Why declare a different type than
what spec defines and keep typecasting it every time? Assuming we don't want to
touch the API, how about the patch attached? 


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.