[Telepathy] [PATCH] TelepathyQt4: Various bugs + patches to fix them

George Kiagiadakis kiagiadakis.george at gmail.com
Mon Jun 15 07:38:26 PDT 2009

Hello everyone,

I have been playing with Tp::AbstractClientApprover and 
Tp::ChannelDispatchOperation this weekend in order to implement an approver 
for my gsoc project (kcall) and I have found some bugs in the implementation 
of those classes in TelepathyQt4. I am attaching some patches to fix them:

Patch 0001 adds a finished() signal in ChannelDispatchOperation in order to 
compy with the specification (I needed to use this signal, so I added it).

Patch 0002 makes ClientApproverAdaptor use the full name of the Connection 
property ("org.freedesktop.Telepathy.ChannelDispatchOperation.Connection") to 
read the Connection object path from the properties that are passed to its 
AddDispatchOperation method, in order to compy with the spec. Before I fix 
that, it would crash a while after the channel dispatcher had called this 
method, because the Connection object was assumed to be valid, although it 

Patch 0003 makes ChannelDispatchOperation read the "Channels" property from 
the remote ChannelDispatchOperation object instead of reading 
"ChannelDetailsLIst", which doesn't exist. This didn't crash before, but the 
channels() method of ChannelDispatchOperation would return an empty list, 
which is wrong.

Best regards,

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ClientApproverAdaptor-Use-the-dbus-qualified-name-to.patch
Type: text/x-patch
Size: 1495 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/telepathy/attachments/20090615/2f891310/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ChannelDispatchOperation-Add-finished-signal.patch
Type: text/x-patch
Size: 1676 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/telepathy/attachments/20090615/2f891310/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-ChannelDispatchOperation-Read-the-Channels-property-.patch
Type: text/x-patch
Size: 1147 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/telepathy/attachments/20090615/2f891310/attachment-0002.bin 

More information about the telepathy mailing list