[Telepathy] [PATCH] Geoclue: check for errors, validity and bail when setting up

[Pierre-Luc Beaudoin]

On Thu, 2009-06-18 at 17:28 +0900, Niv Sardi wrote:
> 
> in setup_geoclue:libempathy-gtk/empathy-location-manager.c we call
> geoclue_master_create_client () without checking it actually returns
> anything or giving it a GError pointer.

Hi,

Thanks for you patch, but we were already aware of that bug and it has
been fixed the day after the release as can be seen here:
http://bugzilla.gnome.org/show_bug.cgi?id=585887

This bug is triggered when you have built with libgeoclue, but are not
running geoclue (missing packages such as geoclue and geoclue-*).  By
the way, don't install geoclue-example, it screws the location
determination process.

On a side note, we prefer receiving patches on bug reports it makes it
easier to manage in quantity and track their status.

Thanks again,

Pierre-Luc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/telepathy/attachments/20090618/1cc6aa5d/attachment.pgp