[Telepathy] [Bug 16170] TpIntSet should cope with larger integers

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Apr 9 04:02:23 PDT 2010


https://bugs.freedesktop.org/show_bug.cgi?id=16170

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://git.collabora.co.uk/
                   |                            |?p=user/smcv/telepathy-glib
                   |                            |-smcv.git;a=shortlog;h=refs
                   |                            |/heads/sparse-intset
             Status|NEW                         |ASSIGNED
           Keywords|                            |patch
           Severity|normal                      |enhancement
           Priority|medium                      |high
         AssignedTo|telepathy at lists.freedesktop |simon.mcvittie at collabora.co
                   |.org                        |.uk
          QAContact|                            |telepathy at lists.freedesktop
                   |                            |.org

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-04-09 04:02:23 PDT ---
This is more important now that we're seriously thinking about Bug #23155. This
single patch:

http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=shortlog;h=refs/heads/sparse-intset

changes TpIntSet to be implemented as a hash from guint to guint32 (the 5
lowest bits are represented by a bitfield in the value, and the rest go in the
key).

On 64-bit platforms we could in principle use a hash from guint to 64-bit int,
and put the 6 lowest bits in the value; all the code is there, except that
count_bits32() needs replacing with a version with 64-bit magic numbers (I
didn't really want to waste time researching that right now).

Iteration will be somewhat slower now due to keeping the (undocumented!) rule
that iteration over an int set is ordered, so I also added a TpIntSetFastIter
which has a more GHashTable-like API and iterates out-of-order.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the telepathy mailing list