[Telepathy] [PATCH] Fix crashes in FileTransfer and StreamTubes related to SocketAddressIPv4
Andre Moreira Magalhaes
andre.magalhaes at collabora.co.uk
Mon May 3 11:55:03 PDT 2010
On 03/05/10 14:51, Simon McVittie wrote:
> On Sun, 02 May 2010 at 12:31:34 +0200, Dario Freddi wrote:
>> so after some further debugging with George, we found out the problem that
>> made File transfers and stream tubes crash. It looks like dbus-glib is sending
>> u instead of q, due to the fact that it is not capable of sending q, hence the
>> struct as received by QtDBus is (su).
> There are (meant to be) tests for file transfers in telepathy-qt4. If this is
> because of a workaround in FT, could that workaround be applied elsewhere?
> If not, why aren't the FT tests crashing in the same way?
Actually there is no _test_ for FT in tp-qt4. There are just examples.
This was discussed back when we developed ft support, as it would be a
whole lot of work to write test CMs to test FT, then we agreed that
examples were enough. Also the examples crash randomly here, so I didn't
catch this before.
>> On a side note, I'd propose to change this in Telepathy spec itself, given
>> that as wjt confirmed, u is always used instead of q in some places, and it
>> might lead to similar situations.
> This is<https://bugs.freedesktop.org/show_bug.cgi?id=20776>. There's a branch
> there, although it may need updating. However, I was under the impression that
> it could be worked around in QtDBus/Telepathy-Qt4...
> This would be an ABI break for telepathy-qt4, although possibly only in ABI
> that has never worked.
I vote for updating the spec to use u instead of q and breaking tp-qt4 ABI
More information about the telepathy