[Telepathy] Upstream Qt5 support for telepathy-qt

[John Brooks]

On Jan 22, 2014, at 2:48 AM, David Edmundson <david at davidedmundson.co.uk> wrote:
> Qt5 support is /meant/ to work, There are code paths that search for
> both and did work at some point. Given the dates this was possibly
> made before 5.0 was officially out, it seems in later Qt/Cmake
> releases have broken this.

Looks like you’re right. That port must’ve been done very early in Qt5 development, before the major API breaks. I wonder why the ubuntu packaging chose such a difficult method instead.

> I would really not advise a qmake port. Have a look at the size of
> cmake/modules. It's huge. The equivalent in qmake isn't exactly any
> easier and that's a lot of porting.

Oh, I agree. That idea just comes from me not knowing how hard it is to do dual-building Qt4/Qt5 in cmake. I’m very happy we don’t need to do it.

> and done:
> 
> http://pastebin.kde.org/pf41bfc3e
> 
> Builds on Qt4.8 and Qt5-master.
> Could you test that it works for you.

Wow, much easier than I expected. A few more changes were needed to build tests, and we have a few patches to fix test execution under Qt5 as well. I put all of that at:

https://github.com/special/telepathy-qt-upstream/commits/qt5

That branch builds for me on Qt4 and Qt5 with tests and optional dependencies. If you can submit your patch plus the tests build fix (feel free to squash), I’ll submit our test fixes separately, and we should have a fully working upstream.

Thanks!

- John