[Telepathy] requestHandles method

[Mateus Bellomo]

I was looking to telepathy-morse [1] and telepathy-nonsense [2] and it both
don't add a new contact when requestHandles is called so I was wondering if
there is a particularity in resiprocate so we have to add a contact when
requestHandles is called.


[1]
https://github.com/TelepathyQt/telepathy-morse/blob/master/connection.cpp
[2]
https://github.com/TelepathyQt/telepathy-nonsense/blob/master/connection.cc

2016-06-04 16:29 GMT-03:00 Daniel Pocock <daniel at pocock.pro>:

>
>
> On 04/06/16 21:24, Mateus Bellomo wrote:
> > Hello,
> >
> > I'm implementing tha Aliases interface methods at telepathy-resiprocate
> > and I'm getting some problems when I try to add a contact. Empathy
> > closes unexpectedly and it won't show anything in the empahy-debugger[1].
> >
> > In fact looking at [2] it seems that it shouldn't have line 267 because
> > the function requestHandles [3] should only return the handles for the
> > identifiers passed as parameters.
> >
> > I only get this error when I comment the line 267 from [2]. But If this
> > line is uncommented, while the client is typing to add a new client
> > several contacts are added to the contact list because the function
> > requestHandles is being called several times (I didn't found yet who is
> > calling this function).
> >
> > Anyone have a clue of why we have to add a contact every time the
> > function requestHandles is called?
> >
>
>
> ensureHandle() should only create a handle for a contact if it doesn't
> already have a handle
>
> I believe this is the way it should work, I think this is logic I copied
> from one of the other connection managers
> _______________________________________________
> telepathy mailing list
> telepathy at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/telepathy
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/telepathy/attachments/20160604/19a7fbfb/attachment-0001.html>