[Uim-bugs] [Bug 3684] Corrupted data structure in uim-xim

[bugzilla-daemon at freedesktop.org]

Please do not reply to this email: if you want to comment on the bug, go to    
       
the URL shown below and enter yourcomments there.     
   
https://bugs.freedesktop.org/show_bug.cgi?id=3684          
     

ekato at ees.hokudai.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From ekato at ees.hokudai.ac.jp  2005-07-02 00:11 -------
> Actually I am not sure why ParseComposeStringFile creates a root node
> to the structure at all, since parse_compose_line should take care of
> creating it on demand. If I am correct about this then the following
> patch should suffice. If I am mistaken about the usefullness of
> creating the root node then the correct fix is rather to initialize the
> three extra fields to sane values.

Good catch!  As you noted, the root node is created in parse_compose_line() with
*top == NULL, so the initialization in XimIM::ParseComposeStringFile is redundant.

Cheers,
--
Etsushi kato
ekato at ees.hokudai.ac.jp          
     
     
--           
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email         
     
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.