[Uim-bugs] [Bug 24123] Add a Qt4 toolbar for uim

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24123





--- Comment #6 from Muneyuki Noguchi <nogu.dev at gmail.com>  2009-09-30 14:15:50 PST ---
> And I've also added qt4 candwin for
> uim-xim and default_toolkit handling.  Could you confirm this work for you?
It works for me as far as I've tested.

> Do you have any plan or motivation to implement this?
I'd like to do it, but it may take a few weeks.

A couple of comments on qt4/candwin/qt4.cpp:

> int len = list.length();
QList::length() was introduced in Qt 4.5. Some distributions ship w/o Qt >=
4.5. OpenSUSE 11.1, for example, uses Qt 4.4. I suggest using QList::count() or
QList::size(). Both are same as QList::length() and exist from Qt 4.0.

> qDebug( "uim-helper-candwin-qt: activateCand()" );
> qDebug( "uim-helper-candwin-qt: selectCand()" );
> qDebug( "uim-helper-candwin-qt: moveCand()" );
> ...
You forgot to change `uim-helper-candwin-qt' in these lines.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.