[uim-commit] r1482 - in trunk: scm uim

[yamaken at freedesktop.org]

Author: yamaken
Date: 2005-09-12 07:23:59 -0700 (Mon, 12 Sep 2005)
New Revision: 1482

Modified:
   trunk/scm/custom-rt.scm
   trunk/uim/uim-custom.c
Log:
* This commit disables the experimental mtime-aware user-config
  reloading feature. See the added comments of uim-custom.c for detail

* uim/uim-custom.c
  - Disable UIM_CUSTOM_EXPERIMENTAL_MTIME_SENSING
  - Add description about the change
* scm/custom-rt.scm
  - (custom-enable-mtime-aware-user-conf-reloading?): Change default
    to #f


Modified: trunk/scm/custom-rt.scm
===================================================================
--- trunk/scm/custom-rt.scm	2005-09-12 14:17:12 UTC (rev 1481)
+++ trunk/scm/custom-rt.scm	2005-09-12 14:23:59 UTC (rev 1482)
@@ -45,7 +45,7 @@
 
 (define custom-full-featured? #f)
 ;; experimental
-(define custom-enable-mtime-aware-user-conf-reloading? #t)
+(define custom-enable-mtime-aware-user-conf-reloading? #f)
 
 (define-record 'custom-choice-rec
   '((sym   #f)

Modified: trunk/uim/uim-custom.c
===================================================================
--- trunk/uim/uim-custom.c	2005-09-12 14:17:12 UTC (rev 1481)
+++ trunk/uim/uim-custom.c	2005-09-12 14:23:59 UTC (rev 1482)
@@ -55,8 +55,23 @@
 #include "context.h"
 #include "uim-helper.h"
 
-#if 1
-/* TODO: make stable */
+#if 0
+/*
+ * The UIM_CUSTOM_EXPERIMENTAL_MTIME_SENSING is disabled since:
+ *
+ * - file_content_is_same() has a bug which may return invalid result
+ *   when the file size is greater than 4095 bytes
+ *
+ * - The codes aim to save custom-groups that some changes are
+ *   applied, but it should not be achieved by such violent method
+ *   (comparing entire content of saved files). Observing updated
+ *   group in uim-custom client program is recommended way
+ *
+ * - It breaks original behavior. See the comment of
+ *   custom-reload-user-configs in custom-rt.scm
+ *
+ *  -- YamaKen 2005-09-12
+ */
 #define UIM_CUSTOM_EXPERIMENTAL_MTIME_SENSING
 #endif