Does recent uim work on 64bit system? (was: Re: [Uim] Re: uim 0.4.5 released)

[TOKUNAGA Hiroyuki]

Hi,

On Mon, 20 Dec 2004 06:15:35 +0900
TOKUNAGA Hiroyuki <tkng at xem.jp> wrote:

> > There may be a 64 bit problem with uim-toolbar-gtk though.  When I
> > start uim-toolbar-gtk on a 64 bit machine running the current
> > development version of SuSE Linux, the toolbar appears but nothing
> > happens when I click on the toolbar.
> 
> Oops, I noticed that latest uim-toolbar-gtk doesn't work also on my
> machine. (It's IBM thinkpad, of course 32 bit CPU.) But on my machine,
> uim-toolbar-gtk-systray works well. Does uim-toolbar-gtk-systray work
> on your 64 bit machine? If so, maybe I can fix the bug.

I fixed this bug (= standalone uim-toolbar-gtk doesn't work on my
machine). I suspect that version difference of GTK+ may causes the
problem. I'm using GTK+ 2.6. i.e. uim-toolbar-gtk may not work with GTK+
2.6. If your 64 bit machine has GTK+ 2.6 and 32 bit machine has GTK+
2.4, my guess would be correct likely.

Following patch will fix the problem. Or use latest daily svn snapshot
if you encountered the bug.


Index: helper/toolbar-standalone-gtk.c
===================================================================
--- helper/toolbar-standalone-gtk.c     (revision 51)
+++ helper/toolbar-standalone-gtk.c     (working copy)
@@ -162,7 +162,14 @@
 static void
 size_request_cb(GtkWidget *widget, GtkRequisition *req, gpointer data)
 {
-  gtk_window_resize(GTK_WINDOW(widget), req->width, req->height);
+  if (GTK_WIDGET_MAPPED(widget)) {
+    gint width, height;
+    gtk_window_get_size(GTK_WINDOW(widget), &width, &height);
+
+    if(width != req->width || height != req->height) {
+      gtk_window_resize(GTK_WINDOW(widget), req->width, req->height);
+    }
+  }
 }

 int



Regards,

-- 
TOKUNAGA Hiroyuki
http://kodou.net/