[VDPAU] [PATCH] Detect libflashplayer through /proc/self/maps

[Jeroen Roovers]

On Thu, 21 Nov 2013 22:40:50 +0200
Anssi Hannula <anssi.hannula at iki.fi> wrote:

> 13.11.2013 01:44, Jeroen Roovers kirjoitti:
> > Parsing /proc/self/cmdline does not always detect libflashplayer
> > since not every browser includes that string. /proc/self/maps will
> > always map the library we are looking for, so we use that instead.
> [...]
> 
> This patch causes various false positives.

Just to bring an end to this thread (I have already proposed a new
patch which works around the Adobe Flash problem specifically for
people running Opera). The thing is, you were never taking in browsers
that do not do OOP plugins to begin with, with the logic you had in
place. Any browser that would run plugins (like Adobe Flash) in the
same process as the browser itself would not have "libflashplayer" in
argv(), therefore you were already causing false negatives.

My original patch didn't do anything to relieve that problem, true, but
it did mitigate the problem for (modern) browsers that _do_ do OOP
plugins. Since I apparently failed to convince you in that respect,
I'll just leave you at it. I'll just keep hoping the new Opera specific
patch is accepted.


     jer