[VDPAU] [PATCH] test: add a dlclose test

Robert Morell rmorell at nvidia.com
Fri Jan 25 14:36:41 PST 2013


On Fri, Jan 25, 2013 at 09:45:48AM -0800, Aaron Plattner wrote:
> Closing an X display that had a VDPAU device created on it causes a crash.
> 
> Work around an identical libXext dlclose bug with the "Generic Event Extension"
> by dlopening libXext.so.6 and leaving it open.
> 
> Original bug discovered and fixed by Robert Morell <rmorell at nvidia.com> in
> commit 3b43955c7324e1d213a3134387767722f34e2356.
> 
> v2: Don't SKIP if creating the device fails.  Just attempting to create the
> device installs the DRI2 extension that causes the problem.
> 
> Signed-off-by: Aaron Plattner <aplattner at nvidia.com>
> ---
> Good call.  New version that just ignores failures to create the device.  I
> verified that this still FAILs without Robert's change and PASSes with his
> change on an NV40 that doesn't support VDPAU.
> 
>  .gitignore       |  1 +
>  Makefile.am      |  2 +-
>  configure.ac     |  1 +
>  test/.gitignore  |  1 +
>  test/Makefile.am |  6 ++++++
>  test/dlclose.c   | 64 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  6 files changed, 74 insertions(+), 1 deletion(-)
>  create mode 100644 test/.gitignore
>  create mode 100644 test/Makefile.am
>  create mode 100644 test/dlclose.c
> 
> diff --git a/.gitignore b/.gitignore
> index 2ae1e06..b0d239c 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -24,4 +24,5 @@ missing
>  *.la
>  *.o
>  stamp-h1
> +test-driver

Did you mean to add this .gitignore hunk?  I don't see anything related
to it in the rest of the patch.

Either way,

Reviewed-by: Robert Morell <rmorell at nvidia.com>

Thanks for writing this test.


More information about the VDPAU mailing list