[VDPAU] [PATCH] Detect libflashplayer through /proc/self/maps

[Jeroen Roovers]

On Wed, 13 Nov 2013 08:46:22 +0100
Rémi Denis-Courmont <remi at remlab.net> wrote:

> On Wed, 13 Nov 2013 00:44:53 +0100, Jeroen Roovers <jer at gentoo.org>
> wrote:
> > Parsing /proc/self/cmdline does not always detect libflashplayer
> > since not every browser includes that string. /proc/self/maps will
> > always map the library we are looking for, so we use that instead.
> 
> If the browser loads Flash in a separate process, it will be fine. But
> what if the browser has Flash and other video playback plugins (HTML,
> Totem, VLC, whatever) in the same process? Is it so that all browsers
> load Flash in isolation?

In testing this patch, I haven't come across a browser that (still)
loads all plugins in the same process. Even Firefox has switched away
from that (bad) practice in recent years.

Additionally, browsers which do load all plugins in the main process
would probably not add an arbitrary string like "libflashplayer" to
cmdline (or they would be adding all other plugins' names to
cmdline, too?), which is what the unpatched libvdpau code tests for
anyway.


     jer