[VDPAU] [PATCH] vdpauinfo: remove is_supported initializers

[José Hiram Soltren]

This looks good to me. In general, it is my preference for vdpauinfo to query
the VDPAU spec as written, as opposed to being tied to the quirks of a
particular vendor's particular version of a particular VDPAU implementation.
This change does exactly this.

Thanks,
--José

On 10/21/2013 05:09 PM, Aaron Plattner wrote:
> These variables were initialized to work around a bug in the NVIDIA driver where
> the is_supported output parameter was only initialized if the feature being
> queried was not supported.  This was fixed in the 190.* driver release series,
> making the workaround unnecessary.
> 
> Signed-off-by: Aaron Plattner <aplattner at nvidia.com>
> ---
>  vdpauinfo.cpp | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/vdpauinfo.cpp b/vdpauinfo.cpp
> index 205afd4..eb31d01 100644
> --- a/vdpauinfo.cpp
> +++ b/vdpauinfo.cpp
> @@ -108,7 +108,7 @@ void queryVideoSurface(VDPDeviceImpl *device)
>      printf("-------------------------------------------\n");
>      for(int x=0; x<chroma_type_count; ++x)
>      {
> -        VdpBool is_supported = false;
> +        VdpBool is_supported;
>          uint32_t max_width, max_height;
>  
>          rv = device->VideoSurfaceQueryCapabilities(device->device, chroma_types[x].id,
> @@ -120,7 +120,6 @@ void queryVideoSurface(VDPDeviceImpl *device)
>              /* Find out supported formats */
>              for(int y=0; y<ycbcr_type_count; ++y)
>              {
> -                is_supported = false;
>                  rv = device->VideoSurfaceQueryGetPutBitsYCbCrCapabilities(
>                      device->device, chroma_types[x].id, ycbcr_types[y].id,
>                      &is_supported);
> @@ -143,7 +142,7 @@ void queryOutputSurface(VDPDeviceImpl *device)
>      printf("----------------------------------------------------\n");
>      for(int x=0; x<rgb_type_count; ++x)
>      {
> -        VdpBool is_supported, native=false;
> +        VdpBool is_supported, native;
>          uint32_t max_width, max_height;
>  
>          rv = device->OutputSurfaceQueryCapabilities(device->device, rgb_types[x].id,
> @@ -157,7 +156,6 @@ void queryOutputSurface(VDPDeviceImpl *device)
>              /* Find out supported formats */
>              for(int y=0; y<ycbcr_type_count; ++y)
>              {
> -                is_supported = false;
>                  rv = device->OutputSurfaceQueryPutBitsYCbCrCapabilities(
>                      device->device, rgb_types[x].id, ycbcr_types[y].id,
>                      &is_supported);
> @@ -263,7 +261,8 @@ void queryVideoMixer(VDPDeviceImpl *device)
>      printf("------------------------------------\n");
>      for(int x=0; x<mixer_features_count; ++x)
>      {
> -        VdpBool is_supported = true; /* There seems to be a bug in VideoMixerQueryFeatureSupport, is_supported is only set if the feature is not supported */
> +        VdpBool is_supported;
> +
>          rv = device->VideoMixerQueryFeatureSupport(device->device, mixer_features[x].id,
>              &is_supported);
>          is_supported = (rv == VDP_STATUS_OK && is_supported);
> @@ -277,7 +276,7 @@ void queryVideoMixer(VDPDeviceImpl *device)
>      printf("-----------------------------------------------------\n");
>      for(int x=0; x<mixer_parameters_count; ++x)
>      {
> -        VdpBool is_supported = false;
> +        VdpBool is_supported;
>  
>          rv = device->VideoMixerQueryParameterSupport(device->device, mixer_parameters[x].id,
>              &is_supported);
> @@ -302,7 +301,7 @@ void queryVideoMixer(VDPDeviceImpl *device)
>      printf("-----------------------------------------------------\n");
>      for(int x=0; x<mixer_attributes_count; ++x)
>      {
> -        VdpBool is_supported = false;
> +        VdpBool is_supported;
>  
>          rv = device->VideoMixerQueryAttributeSupport(device->device, mixer_attributes[x].id,
>              &is_supported);
> @@ -356,7 +355,7 @@ void queryDecoderCaps(VDPDeviceImpl *device)
>      printf("-------------------------------------------\n");
>      for(int x=0; x<decoder_profile_count; ++x)
>      {
> -        VdpBool is_supported = false;
> +        VdpBool is_supported;
>          uint32_t max_level, max_macroblocks, max_width, max_height;
>  
>          rv = device->DecoderQueryCapabilities(device->device, decoder_profiles[x].id,
> 
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------