[VDPAU] [PATCH] Enable Lossless Decode Capabilities via VDPAU API

José Hiram Soltren jsoltren at nvidia.com
Wed Dec 10 07:01:15 PST 2014


Hello,

On 12/10/2014 08:04 AM, Rémi Denis-Courmont wrote:
> Le 2014-12-09 20:25, José Hiram Soltren a écrit :
>>> Should we continue with residual_color_transform_flag or change to
>>> separate_colour_plane_flag as mentioned in the spec?
>>
>> I think separate_colour_plane_flag is the better choice. I was mistaken:
>> residual_color_transform_flag is an ffmpeg-ism. I don't see it in the spec.
> 
> FWIW, transform_bypass is also a libavcodec'ism. The proper name is
> qpprime_y_zero_transform_bypass_flag (ouch!).

Indeed it is, thanks for catching this.

I prefer for our VdpPictureInfo field names to match the specifications when
possible. So, I vote for replacing "transform_bypass" with
"qpprime_y_zero_transform_bypass_flag".

Still, I suggest that we keep the line about drivers being able to accept
values greater than one here, to work around potential encoder bugs.

Thanks,
--José


More information about the VDPAU mailing list