[VDPAU] [PATCH] Fix incorrect VdpDecoderRender signature.

[Reimar Döffinger]

On Tue, Feb 18, 2014 at 02:24:28PM -0800, Stephen Warren wrote:
> Reimar Döffinger wrote at Tuesday, February 18, 2014 2:40 PM:
> > There is no "struct VdpPictureInfo" I can see anywhere? (and that is
> > almost certainly intentional since adding a new, larger
> > VdpPictureInfoSomething would break API/ABI if there was such a generic
> > type)
> 
> Correct; the patch above should create an undefined struct type.
> Perhaps you'd need to add "struct VdpPictureInfo" too.
> 
> > It would mean you could no longer pass in a VdpPictureInfoMPEG1Or2 *
> > without needing a cast.
> 
> I think you'd already need a cast, since no code is passing the current
> parameter type either, and since it's not void*, the conversion shouldn't
> be automatic. This should warn with any reasonable warning level.

Right, I didn't notice because it was a void * on my side that I passed
in.

> 
> > There is also the problem that this would change API more
> > significantly.
> > If someone placed a VdpPictureInfo field into a struct for example
> > this change will break their code, since it refuses to compile.
> 
> Why would you do that?

No idea, just saying that it would break such code if someone did that.
Just a compatibility questions.
If that's nothing you worry about, that seems like a reasonable
approach.
I'd have to test and update the documentation for that.