[VDPAU] Should we export these functions ? (Re: Exporting the flash workaround functions)

[Emil Velikov]

José Hiram Soltren wrote:
> As for the DRI2 functions referenced in src/vdpau_wrapper.c: I don't see a
> reason for these to be non-static either. We implement our own mesa_dri2.c
> in libvdpau and only use this internally. I've CC'd Aaron who might be able
> to comment further. You are probably correct here as well.

José,

Thanks for the input. Yet, I do not see how one can define a function as
static and then use it in another source file. Perhaps I'm missing something ?

Aaron Plattner wrote:
> Correct, those symbols should not be exported.  -fvisiblity=hidden or
> equivalent options sound like the right way to go there on sufficiently
> new compilers, though there are also no prototypes for them in the
> public API headers so it should be obvious that they're not part of the
> exported ABI...

That's exactly what I had planned Aaron. Check if the compiler supports
-fvisibility... and add a couple of symbols (PUBLIC & PRIVATE) in a private
header. Then explicitly annotate the symbols where required. Thanks for the
confirmation.

Will try to find some time over the weekend.

Thanks gents,
Emil

P.S. Was not subscribed to the list, so I had to butcher your replies from the
ML archive. Just subscribed so I won't miss any replies :)