[VDPAU] [PATCH 3/3] vdpau_wrapper: wrap decoder_create and decoder_query_capabilities

[Rémi Denis-Courmont]

Le mardi 28 octobre 2014, 13:56:48 José Hiram Soltren a écrit :
> This is of course technically fine, and a future version of the NVIDIA VDPAU
> driver (libvdpau_nvidia.so) could implement this natively.
> 
> I worry, though, that this workaround is always enabled, even on new drivers
> supporting the new attributes you added in patch 2 of this patch set? Now
> that I think about it more, patch 2 should also increment VDPAU_VERSION so
> that a video player can use VdpGetApiVersion() to see if the new profiles
> are supported.

That´s another option but then the third patch can be binned completely :-o

Well, I don´t particular like the GetProcAddress wrapper anyway. It is 
currently not reentrant (proposed fixes sent) and cannot deal with multiple 
drivers (a fix would be very involved).

> Would it make sense to condition this functionality on a new config
> attribute defined in init_config(), such as enable_h264_profile_workaround,
> that we default to either true or false? Users and/or distribution
> maintainers could then toggle the workaround with vdpau_wrapper.cfg.

The configuration file seems impractical. For instance, Debian already carries 
Mesa, NVIDIA and VA-GL drivers. They cannot have a single setting to control 
all three of them... and once all drivers would be updated, they might as well 
disable the workaround at build-time.

> In addition, the wrapper itself could check the reported VDPAU version API,
> and enable this workaround conditionally.

The VDPAU version might work.

> This could be in conjunction with, or instead of, the config option.

-- 
Rémi Denis-Courmont
http://www.remlab.net/