[VDPAU] [PATCH 1/4] trace: use intermediate static library in the build

[Emil Velikov]

On 19 March 2015 at 07:45, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le 2015-03-19 02:50, Emil Velikov a écrit :
>>
>> Compile the source into a static library, to prevent C++ linkage. The
>> latter of which unnesseserally pulls libm, libgcc_s and libstdc++ as
>> dependencies.
>
>
> I think that's wrong. If a library has C++ code, it depends on libsdtc++ and
> that's the end of the story. The rest is an implementation detail of the
> compiler.
>
Just because something is written in C++ that does not have to mean
that it depends on the C++ runtime. This is one good example of such a
case. Afaict the reason behind using C++ (over C) here is to make use
of the additional type safety (possibly others).

> I hate it when some library depends on stdc++ but fails to pull it, leaving
> it up to the application. Well nNot that my personal taste matters, but
> doing that also breaks packaging policies in distros.
>
I don't see any reason for hate. Have you checked the library before
and after this patch - its actual use and dependency of the said
libraries ? On the packaging side nothing is broken (be that policy or
package) as nothing is required/used from the runtime.

> If you really want to avoid C++ linkage, I think you should convert the code
> to C.
>
Keep in mind the additional type safety mentioned above. If Aaron and
others feel strongly this way, so be it.

Cheers,
Emil