[VDPAU] secure_getenv() patch for libvdpau

Stefan Dirsch sndirsch at suse.de
Mon Sep 7 03:17:17 PDT 2015


On Fri, Sep 04, 2015 at 03:53:56PM -0700, Aaron Plattner wrote:
> On 09/04/2015 08:04 AM, Jose Soltren wrote:
> > Forwarding on Stefan's behalf.
> > 
> > From: Stefan Dirsch <sndirsch at suse.de>
> > Sent: Friday, September 4, 2015 08:31
> > To: Jose Soltren
> > Subject: secure_getenv() patch for libvdpau
> > 
> > Hi José Hiram
> > 
> > Unfortunately your patch
> > 
> > commit d1f9c16b1a8187110e501c9116d21ffee25c0ba4
> > Author: José Hiram Soltren <jsoltren at nvidia.com>
> > Date:   Mon Aug 17 16:01:44 2015 -0500
> > 
> >     Use secure_getenv(3) to improve security
> > 
> > in libvdpau git resulted in a build warning ("implicit declaration of
> > secure_getenv(...)"), which SUSE treats as fatal error. Find a patch attached,
> > which fixes this issue for me.
> 
> Hi Stefan,
> 
> Can you please try Rico's patch from Tuesday?
> http://lists.freedesktop.org/archives/vdpau/2015-September/000379.html
> http://lists.freedesktop.org/archives/vdpau/attachments/20150901/88173bbf/attachment.bin

Just tried. Works fine for me. And looks more reasonable to me than mine. ;-)

> If that works for you, I'll add that with your Tested-by line.

You do have my "Tested-by" line, i.e. "Stefan Dirsch: <sndirsch at suse.com> if
that is useful.

> Do you need a libvdpau-1.1.2 release to pick up this fix?

No. I don't. But I guess it would be useful for others. ;-)

Thanks,
Stefan

Public Key available
------------------------------------------------------
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0            Maxfeldstraße 5
FAX: 0911-740 53 479          D-90409 Nürnberg
http://www.suse.de            Germany 
---------------------------------------------------------------
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---------------------------------------------------------------


More information about the VDPAU mailing list