<html> <head> <meta content="text/html; charset=utf-8" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">Hi Zach, your understanding is incorrect. Rémi already explained it correctly that the result of secure_getenv() can only change when somebody modifies the environment of the process in another thread at the same time and that behavior is undefined with or without your patch. So your patch actually doesn't help in any way. Regards, Christian. Am 18.02.2016 um 01:27 schrieb Zach Angold: </div> <blockquote cite="mid:alpine.DEB.2.11.1602171606190.14882@zangold-dev" type="cite"> <pre wrap="">I think I might have miscommunicated what bug I was trying to address with this patch. Consider the following: x = secure_getenv("foo") y = secure_getenv("bar") print(x) In my understanding, the above pseudocode could print out either $foo or $bar, depending on whether the return value of getenv() is implemented to be statically allocated. What I'm trying to accomplish by replacing secure_getenv with safe_secure_getenv is to (for example) have the above print out $foo regardless of the implementation of secure_getenv. </pre> <fieldset class="mimeAttachmentHeader"></fieldset> <pre wrap="">_______________________________________________ VDPAU mailing list <a class="moz-txt-link-abbreviated" href="mailto:VDPAU@lists.freedesktop.org">VDPAU@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/vdpau">https://lists.freedesktop.org/mailman/listinfo/vdpau</a> </pre> </blockquote> </body> </html>