[virglrenderer-devel] [PATCH] virtio-gpu-3d: add support for second capability set

[Dave Airlie]

On 16 February 2018 at 18:54, Gerd Hoffmann <kraxel at redhat.com> wrote:
>> +    } else if (info.capset_index == 1) {
>> +        resp.capset_id = VIRTIO_GPU_CAPSET_VIRGL2;
>> +        virgl_renderer_get_cap_set(resp.capset_id,
>> +                                   &resp.capset_max_version,
>> +                                   &resp.capset_max_size);
>
>> +#ifdef VIRGLRENDERER_SUPPORTS_CAPSET2
>> +        g->virtio_config.num_capsets = 2;
>> +#endif
>
> Not going to fly.  The virglrenderer version you compile against may be
> a different than the one used by the binary.  I think instead of
> depending on the #define qemu should just try call
> virgl_renderer_get_cap_set(VIRTIO_GPU_CAPSET_VIRGL2) and see if that
> works.
>

I did realise this after, it actually would work as the get_cap_set API
works, but then it would make sense to just call it and see if you get
a max_version > 2.

I'll fix it on Monday.

Thanks,
Dave.

> cheers,
>   Gerd
>