[virglrenderer-devel] [PATCH 00/16] Fix warnings in gallium/auxiliary/*

[Gert Wollny]

Am Dienstag, den 05.06.2018, 14:42 +1000 schrieb Dave Airlie:
> On 5 June 2018 at 01:53, Gurchetan Singh <gurchetansingh at chromium.org
> > wrote:
> > I've always wondered why building Mesa (and Gallium) always spewed
> > out so many warnings.  Would it be possible to fix this in upstream
> > Mesa, and have the changes trickle down to here when update our
> > Gallium code?  I know we've forked Gallium, but is the fork hard
> > enough that this would not work (we essentially support a few more
> > outdated TGSI opcodes [TGSI_OPCODE_SCS etc.])?
> 
> I'm also worried about this diverging us from Mesa more than we'd
> want to, syncing is already getting difficult but I'm not sure I'd
> too add too many more obstacles.

Fair enough. 

> It might be nice to try and approach mesa with these fixes first.

I'll submit the adjusted patch set to mesa, there is quite a number of 
developers willing to review warning-fixing patches.

I will then convert these patches to virglrenderer so that most of the
fixes should also be in here.

> Though I think we should apply the virgl ones, also with gcc 8.1 we
> get a lot of string warnings in my local builds, which might take a
> bit of work to cleanup.
The second set needs the first patch from this series (i.e. the macro 
VREND_UNUSED(X)), but apart from that the two sets are independend.

Best, 
Gert 

> 
> Dave.
> 
> > On Thu, May 31, 2018 at 2:16 AM Gert Wollny <gert.wollny at collabora.
> > com> wrote:
> > > 
> > > Dear all,
> > > 
> > > this patch series fixes all the warnings that gcc raises when
> > > compiling
> > > with -Wall -Wextra (mostly -Wsigne-compare and -Wunused
> > > parameters).
> > > 
> > > Thanks for reviewing,
> > > Gert
> > > 
> > > PS: I'm working on doing the same vor the remaining source files.
> > > 
> > > Gert Wollny (16):
> > >   gallium/auxiliary/util: Add macro to silence unused parameter
> > > warning
> > >   gallium/aux/cso_cache.c: Fix warnings
> > >   gallium/aux/tgsi/tgsi_build.c: Fix warnings
> > >   gallium/aux/tgsi/tgsi_dump.c: Fix warnings
> > >   gallium/aux/tgsi/tgsi_parse.c: Fix warnings
> > >   gallium/aux/tgsi/tgsi_sanity.c: Fix warnings
> > >   gallium/aux/util/u_debug_refcnt.h: Fix warnings:
> > >   gallium/aux/tgsi/tgsi_text.c: Fix warnings
> > >   gallium/aux/util/u_surface.c: Fix warning
> > >   gallium/aux/tgsi/tgsi_ureg.*: Fix warnings
> > >   gallium/aux/tgsi/tgsi_util.c: Fix warnings
> > >   gallizm/aux/util/u_format.c: Fix warnings
> > >   gallium/aux/util/u_cpu_detect.h: Fix warning in u_cpu_detect.c
> > >   gallium/aux/tgsi/tgsi_scan.c: Fix warnings
> > >   gallium/auxiliary/util/u_debug.c: Fix warnings
> > >   gallium/auxiliary/util/u_debug.h: Fix "noreturn" warnings in
> > > debug
> > >     mode
> > > 
> > >  src/gallium/auxiliary/cso_cache/cso_cache.c   |  6 ++++++
> > >  src/gallium/auxiliary/tgsi/tgsi_build.c       |  9 +++++++--
> > >  src/gallium/auxiliary/tgsi/tgsi_dump.c        |  2 +-
> > >  src/gallium/auxiliary/tgsi/tgsi_parse.c       |  9 +++++++--
> > >  src/gallium/auxiliary/tgsi/tgsi_sanity.c      |  4 ++--
> > >  src/gallium/auxiliary/tgsi/tgsi_scan.c        |  2 +-
> > >  src/gallium/auxiliary/tgsi/tgsi_text.c        |  8 ++++----
> > >  src/gallium/auxiliary/tgsi/tgsi_ureg.c        | 10 +++++++---
> > >  src/gallium/auxiliary/tgsi/tgsi_ureg.h        |  4 ++--
> > >  src/gallium/auxiliary/tgsi/tgsi_util.c        |  2 ++
> > >  src/gallium/auxiliary/util/u_cpu_detect.h     |  2 +-
> > >  src/gallium/auxiliary/util/u_debug.c          |  6 ++++++
> > >  src/gallium/auxiliary/util/u_debug.h          |  6 ++++--
> > >  src/gallium/auxiliary/util/u_debug_describe.c |  1 +
> > >  src/gallium/auxiliary/util/u_debug_refcnt.h   |  5 +++++
> > >  src/gallium/auxiliary/util/u_format.c         |  2 +-
> > >  src/gallium/auxiliary/util/u_surface.c        |  2 +-
> > >  17 files changed, 58 insertions(+), 22 deletions(-)
> > > 
> > > --
> > > 2.16.1
> > > 
> > > _______________________________________________
> > > virglrenderer-devel mailing list
> > > virglrenderer-devel at lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/virglrenderer-deve
> > > l
> > 
> > _______________________________________________
> > virglrenderer-devel mailing list
> > virglrenderer-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/virglrenderer-devel
> 
> _______________________________________________
> virglrenderer-devel mailing list
> virglrenderer-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/virglrenderer-devel