[virglrenderer-devel] [PATCH 1/2] vrend: fix dual src blending.

[Jakob Bornecrantz]

On 2018-05-22 02:17, Dave Airlie wrote:
> On 22 May 2018 at 00:26, Elie Tournier <tournier.elie at gmail.com> wrote:
>> On Mon, May 21, 2018 at 12:42:56PM +1000, Dave Airlie wrote:
>>> From: Dave Airlie <airlied at redhat.com>
>>>
>>> For dual src blending to work we have to link the shader in a certain
>>> way, so we have to dirty the shaders on a new blend state, then
>>> we have to make sure the dual src bit is the same before avoiding
>>> a relink state, otherwise have to relink.
>>>
>>> This fixes:
>>> piglit arb_blend_func_extended-fbo-extended-blend
>>
>> This series makes more good than bad.
>> See attached.
>> I didn't investigate more.
> 
> Can you confirm, and maybe check if patch 1 or 2 is responsible,
> 
> I've ran a few subsets for deqp compares on master and this set and
> see the same fails.

I pushed these two patches to master, what was not noted was that I also 
tested them on CTS Android GLES[2-3] and showed no regressions, so they are:

Tested-by: Jakob Bornecrantz <jakob at collabora.com>

Cheers, Jakob.