[virglrenderer-devel] [PATCH 2/5] vrend: remove now useless warning messages for glGetTexImage

Gert Wollny gert.wollny at collabora.com
Fri Jun 15 17:50:54 UTC 2018


Since the code path emmiting these warnings is no longer used, remove
them and, because with this removal the ctx parameter is now unused,
remove it as well.

Signed-off-by: Gert Wollny <gert.wollny at collabora.com>
---
 src/vrend_renderer.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/src/vrend_renderer.c b/src/vrend_renderer.c
index 3af5216..e35cc3f 100644
--- a/src/vrend_renderer.c
+++ b/src/vrend_renderer.c
@@ -6061,8 +6061,7 @@ static void vrend_resource_buffer_copy(UNUSED struct vrend_context *ctx,
    glBindBuffer(GL_COPY_WRITE_BUFFER, 0);
 }
 
-static void vrend_resource_copy_fallback(struct vrend_context *ctx,
-                                         struct vrend_resource *src_res,
+static void vrend_resource_copy_fallback(struct vrend_resource *src_res,
                                          struct vrend_resource *dst_res,
                                          uint32_t dst_level,
                                          uint32_t dstx, uint32_t dsty,
@@ -6149,15 +6148,11 @@ static void vrend_resource_copy_fallback(struct vrend_context *ctx,
          if (compressed) {
             if (vrend_state.have_arb_robustness)
                glGetnCompressedTexImageARB(ctarget, src_level, transfer_size, tptr + slice_offset);
-            else if (vrend_state.use_gles)
-               report_gles_missing_func(ctx, "glGetCompressedTexImage");
             else
                glGetCompressedTexImage(ctarget, src_level, tptr + slice_offset);
          } else {
             if (vrend_state.have_arb_robustness)
                glGetnTexImageARB(ctarget, src_level, glformat, gltype, transfer_size, tptr + slice_offset);
-            else if (vrend_state.use_gles)
-               report_gles_missing_func(ctx, "glGetTexImage");
             else
                glGetTexImage(ctarget, src_level, glformat, gltype, tptr + slice_offset);
          }
@@ -6251,7 +6246,7 @@ void vrend_renderer_resource_copy_region(struct vrend_context *ctx,
 
    if (!vrend_format_can_render(src_res->base.format) ||
        !vrend_format_can_render(dst_res->base.format)) {
-      vrend_resource_copy_fallback(ctx, src_res, dst_res, dst_level, dstx,
+      vrend_resource_copy_fallback(src_res, dst_res, dst_level, dstx,
                                    dsty, dstz, src_level, src_box);
 
       return;
-- 
2.17.1



More information about the virglrenderer-devel mailing list