[virglrenderer-devel] [PATCH] renderer: add texture view internals (v3)

[Dave Airlie]

On 22 June 2018 at 12:27, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> This adds the renderer support for exposing texture views.
>
> The change adds support to sampler views and surfaces for the backing
> object to be a separately allocated textureview instead of the actual
> resource. It also adds support for parsing the updated packet where
> we put the sampler view target in the top 8 bits of the format,
> which should be safe as up until now it's always 0.
>
> This doesn't do the final enable of the extension, but it will
> cause us to use views in a few places we didn't before so could have
> some other side effects
>
> v2: check for buffers on surface creation, reword comment
> to better explain if statement.
> v3: fix logic bug (Gert). This uncovered a wierd corner case, possibly
> due to how the state tracker allocates textures, but it tries to create
> a surface with more layers than there are, I think it then reallocate
> the whole texture object in the guest and it works out in the end,
> this adds check to catch this, and to avoid creating a texture view
> in that case.

Ignore this, I worked out what is going on, 3D texture, will think
a bit harder and send a new version.

Dave.