[virglrenderer-devel] [PATCH 1/3] vrend, allocal_texture: Set mip-map levels correctly in the texture's state

[Dave Airlie]

On 25 June 2018 at 21:29, Gert Wollny <gert.wollny at collabora.com> wrote:
> Am Freitag, den 22.06.2018, 12:34 +1000 schrieb Dave Airlie:
>> On 20 June 2018 at 19:02, Gert Wollny <gert.wollny at collabora.com>
>> wrote:
>> > OpenGL defaults GL_TEXTURE_MIN_FILTER=GL_NEAREST_MIPMAP_LINEAR and
>> > GL_TEXTURE_MAX_LEVEL=1000, and expects all these mip-map levels to
>> > be
>> > defined. With glTexStorage this is set apropriately, but when the
>> > mip-map
>> > levels are initialiazed manually, then the GL_TEXTURE_MAX_LEVEL
>> > must be set.
>>
>> We do set those on sampler view creation, is there a problem with
>> doing it here?
>>
>> I'm guessing we don't create a sampler view before we get a resource
>> copy I suppose.
>>
>> If that makes sense, R-b me.
> Is this R-b for this patch or the whole series?

Nope :-)
 piglit


./bin/ext_framebuffer_multisample-clip-and-scissor-blit 8 msaa -auto -fbo

and some others in that area seem to regress with these.

Dave.