[virglrenderer-devel] [PATCH] vrend: make temporary buffer used by iovec read/write large enough

Dave Airlie airlied at gmail.com
Fri Mar 2 02:29:35 UTC 2018


On 28 February 2018 at 11:24, Gurchetan Singh
<gurchetansingh at chromium.org> wrote:
> "vrend: Fix iovec read/write for depth" started making of use of
> the bounding box's depth in the fallback path.  It turns out in
> some instances, the temporary buffer used by iovec read/write
> is not large enough, leading to memory corruption.
>
> Let's separate send_size from alloc_size in some cases, since
> glReadnPixels requires it.
>
> With this fix,
>
> dEQP-GLES3.functional.texture.specification.basic_texsubimage3d.rgba32f_3d

This regresses the s3tc tests in piglit, s3tc-texsubimage.

I'll see if I can spot it.

I also blamed an earlier patch, but it's definitely this.

Dave.


More information about the virglrenderer-devel mailing list