[virglrenderer-devel] [PATCH 1/1] Fixes an issue with blitting of sRGB buffers

Jakob Bornecrantz jakob at collabora.com
Thu Mar 29 13:32:55 UTC 2018


On 2018-03-29 04:39, Robert Tarasov wrote:
> Forces using vrend_render_blit_gl if sourceframebuffers is in sRGB
> colorspace. Fixes following tests:
> dEQP-GLES3.functional.fbo.blit.conversion.srgb8_alpha8_to_rgba8
> dEQP-GLES3.functional.fbo.blit.conversion.srgb8_alpha8_to_rgb10_a2
> dEQP-GLES3.functional.fbo.blit.conversion.srgb8_alpha8_to_rgba4
> dEQP-GLES3.functional.fbo.blit.conversion.srgb8_alpha8_to_rgb5_a1
> dEQP-GLES3.functional.fbo.blit.conversion.srgb8_alpha8_to_rgb8
> dEQP-GLES3.functional.fbo.blit.conversion.srgb8_alpha8_to_rgb565
> dEQP-GLES3.functional.fbo.blit.conversion.srgb8_alpha8_to_rg8
> dEQP-GLES3.functional.fbo.blit.conversion.srgb8_alpha8_to_r8

Thanks, tested, reviewed and pushed!

Cheers, Jakob.

> ---
>   src/vrend_renderer.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/src/vrend_renderer.c b/src/vrend_renderer.c
> index 02d26be..9aebc1b 100644
> --- a/src/vrend_renderer.c
> +++ b/src/vrend_renderer.c
> @@ -5872,6 +5872,9 @@ static void vrend_renderer_blit_int(struct vrend_context *ctx,
>          !vrend_format_is_ds(dst_res->base.format))
>         use_gl = true;
>   
> +   if (util_format_is_srgb(src_res->base.format))
> +      use_gl = true;
> +
>      /* different depth formats */
>      if (vrend_format_is_ds(src_res->base.format) &&
>          vrend_format_is_ds(dst_res->base.format)) {
> 



More information about the virglrenderer-devel mailing list