[virglrenderer-devel] [PATCH] vrend: Use glFramebuffer3DOES on GLES

Tomeu Vizoso tomeu.vizoso at collabora.com
Tue May 15 11:38:34 UTC 2018


On 05/15/2018 12:25 PM, Jakob Bornecrantz wrote:
> Newer versions of libepoxy treats glFramebuffer3DEXT and glFramebuffer3DOES as
> different functions. They differ very slightly but it might be best to be as
> proper as possible when it comes to function usage.
> 
> Signed-off-by: Jakob Bornecrantz <jakob at collabora.com>
> ---
>   src/vrend_renderer.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/src/vrend_renderer.c b/src/vrend_renderer.c
> index 55b96db..8beaae1 100644
> --- a/src/vrend_renderer.c
> +++ b/src/vrend_renderer.c
> @@ -1442,6 +1442,9 @@ void vrend_fb_bind_texture(struct vrend_resource *res,
>         if (layer == 0xffffffff)
>            glFramebufferTexture(GL_FRAMEBUFFER_EXT, attachment,
>                                 res->id, level);
> +      else if (vrend_state.use_gles)
> +         glFramebufferTexture3DOES(GL_FRAMEBUFFER_EXT, attachment,
> +                                   res->target, res->id, level, layer);
>         else
>            glFramebufferTexture3DEXT(GL_FRAMEBUFFER_EXT, attachment,
>                                      res->target, res->id, level, layer);

Reviewed-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>

Thanks,

Tomeu


More information about the virglrenderer-devel mailing list