[virglrenderer-devel] [PATCH] vrend: Warn on different type and format when reading back FBOs v2

[Tomeu Vizoso]

On 05/17/2018 01:45 PM, Tomeu Vizoso wrote:
> Reviewed-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>

Sorry about that, but I have just noticed a mistake, see below:

> Thanks,
> 
> Tomeu
> 
> On 05/15/2018 01:58 PM, Jakob Bornecrantz wrote:

[snip]

>> +      if (type != GL_UNSIGNED_BYTE && format != GL_UNSIGNED_INT &&

s/format/type

Regards,

Tomeu

>> +          type != GL_INT && type != GL_FLOAT) {
>> +         glGetIntegerv(GL_IMPLEMENTATION_COLOR_READ_TYPE, &imp);
>> +         if (imp != type) {
>> +            fprintf(stderr, "GL_IMPLEMENTATION_COLOR_READ_TYPE is not 
>> expected native type 0x%x != imp 0x%x\n", type, imp);
>> +         }
>> +      }
>> +      if (format != GL_RGBA && format != GL_RGBA_INTEGER) {
>> +         glGetIntegerv(GL_IMPLEMENTATION_COLOR_READ_FORMAT, &imp);
>> +         if (imp != format) {
>> +            fprintf(stderr, "GL_IMPLEMENTATION_COLOR_READ_FORMAT is 
>> not expected native format 0x%x != imp 0x%x\n", format, imp);
>> +         }
>> +      }
>> +   }
>> +
>>      if (vrend_state.have_arb_robustness)
>>         glReadnPixelsARB(info->box->x, y1, info->box->width, 
>> info->box->height, format, type, send_size, data);
>>      else if (vrend_state.have_gles_khr_robustness)
>>
> _______________________________________________
> virglrenderer-devel mailing list
> virglrenderer-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/virglrenderer-devel