[virglrenderer-devel] [PATCH v3] vrend: enable multisample on GLE host with GLES >= 3.0

[Emil Velikov]

On 21 May 2018 at 10:02, Gert Wollny <gert.wollny at collabora.com> wrote:
> v3: - Properly place if statement to not send GL_SAMPLE_ALPHA_TO_ONE.
>     - Do not set GL_MULTISAMPLE state when on gle host (same as below).
>
> v2: - Do not set GL_SAMPLE_ALPHA_TO_ONE state when on gle host, because it is
>       not supported there. This silences a number of according warnings on the
>       host.
>
Nitpicks:
 - s/gle/gles/
 - revision log be in ascending order and placed further down.


> Multisample fragment operations are part of the OpenGL ES 3.0 spec and
> enabling them doesnt't required the extensions to be listed explicitely.
>
> Fixes:
>
>  dEQP-GLES3.functional.multisample.fbo_max_samples.proportionality_alpha_to_coverage
>  dEQP-GLES3.functional.multisample.fbo_max_samples.proportionality_sample_coverage
>  dEQP-GLES3.functional.multisample.fbo_max_samples.proportionality_sample_coverage_inverted
>  dEQP-GLES3.functional.multisample.fbo_max_samples.sample_coverage_invert
>
> on an GLE host with GLES >= 3.0.
>
Namely here.

> Signed-off-by: Gert Wollny <gert.wollny at collabora.com>
> Reviewed-by: Gurchetan Singh <gurchetansingh at chromium.org> (v1)

When unsure - just git log it ;-)

HTH
Emil