[virglrenderer-devel] [PATCH 0/3] vrend: Fix piglit blit related regressions

Alexandros Frantzis alexandros.frantzis at collabora.com
Fri May 25 13:51:52 UTC 2018


This patchset fixes the piglit regressions introduced by the
blit-with-swizzle patches.

With the patchset applied, the remaining piglit regressions I am seeing
are (but, note, that I am not running a full piglit run, just the tests
Dave mentioned in a previous email):

spec/arb_texture_float/multisample-formats 6 gl_arb_texture_float: pass fail
spec/ext_texture_snorm/fbo-generatemipmap-formats/gl_alpha16_snorm: pass fail
spec/ext_texture_snorm/fbo-generatemipmap-formats/gl_alpha16_snorm npot: pass fail
spec/ext_texture_snorm/fbo-generatemipmap-formats/gl_alpha8_snorm: pass fail
spec/ext_texture_snorm/fbo-generatemipmap-formats/gl_alpha8_snorm npot: pass fail
spec/ext_texture_snorm/fbo-generatemipmap-formats/gl_alpha_snorm: pass fail
spec/ext_texture_snorm/fbo-generatemipmap-formats/gl_alpha_snorm npot: pass fail
spec/ext_texture_snorm/fbo-generatemipmap-formats/gl_luminance16_alpha16_snorm: pass fail
spec/ext_texture_snorm/fbo-generatemipmap-formats/gl_luminance16_alpha16_snorm npot: pass fail
spec/ext_texture_snorm/fbo-generatemipmap-formats/gl_luminance8_alpha8_snorm: pass fail
spec/ext_texture_snorm/fbo-generatemipmap-formats/gl_luminance8_alpha8_snorm npot: pass fail
spec/ext_texture_snorm/fbo-generatemipmap-formats/gl_luminance_alpha_snorm: pass fail
spec/ext_texture_snorm/fbo-generatemipmap-formats/gl_luminance_alpha_snorm npot: pass fail

All the spec/ext_texture_snorm/fbo-generatemipmap-formats/* regressions
were introduced by "vrend: Nop sends to backing iovs for readonly
textures v2", and are fixed by Tomeu's recently proposed "vrend: Copy
from iovec to avoid needing glGetTexImage" patch in the ML.

I am still investigating the spec/arb_texture_float/multisample-formats
6 failure. The current GLSL code to resolve by averaging the sample
values works for power-of-two number of samples but fails for non
power-of-two.

Alexandros Frantzis (3):
  vrend: Support GL blits with integer color formats
  vrend: Support GL blits for multisampled textures
  Revert "vrend: Use red/green with swizzle for luminance/alpha formats"

 src/vrend_blitter.c | 114 +++++++++++++++++++++++++++++++++++++++-----
 src/vrend_blitter.h |  36 ++++++++++----
 src/vrend_formats.c |  27 +++++------
 src/vrend_shader.c  |   2 +-
 src/vrend_shader.h  |   2 +
 5 files changed, 143 insertions(+), 38 deletions(-)

-- 
2.17.0



More information about the virglrenderer-devel mailing list