[virglrenderer-devel] Thoughts about TGSI-to-GLSL and improvements and beyond

[Gert Wollny]

Hello all, 

Am Montag, den 17.09.2018, 10:48 +1000 schrieb Dave Airlie:
> 
> The other option if the realloc overhead is too much is just to move
> to chunked allocations, so we realloc + 4k everytime we need to
> rather than doing it on a string basis. I think we'd just have to
> store a global size or pull around a struct instead of the char *,
> granted glib strings might be a bit cleaner and I've no objections to
> pulling in glib as a dependency either. I'd like to have some idea of
> how much this could improve translation perf, I don't think shader
> translation perf is going to be that bad for us but I'm sure there
> are plenty of cases where using less CPU is going to be better.

Coming back to this ... One of my reasons for proposing glib strings
was that it takes care of properly allocating the strings, and now with
gcc 8.0 moving in we see lots of warnings about string truncation, and
since we should get rid of these warnings I think this might be the
right moment to actually do this code conversion.

What yo you think? 

Best, 
Gert