[virglrenderer-devel] dEQP-GLES3.functional.shader_api.program_binary.* support

[Elie Tournier]

Hi,

I'm working on reducing the number of "Not Supported" tests when running the CTS in the guest.
I just come across the dEQP-GLES3.functional.shader_api.program_binary.* case.
We currently do not support any binary format (GL_NUM_PROGRAM_BINARY_FORMATS = 0),
so tests are tagged as "Not Supported".

This feature was invented in order to be able to cache the result of the program linking.
But it's not applicable to virglrenderer as we left the compilation process before the linker.
However, we can still share binaries provided by the app with the host.

So my question is:
Is this a feature that you want to see in virglrenderer or can we skip it for now?

To my point of view, it is not a good idea as this will compromise the security
of the project. More over, if we still want to implement it, the chance that
the binary provided by the app will be execute in the host is quite low as
the existing drivers consider the HW information and config
(say old kernel lacking feature X) when generating a unique device id.
If that one didn't matches, the cache is not reused.


Have a nice day,
Elie