<div dir="ltr"><div>Reviewed-by: Gurchetan Singh <<a href="mailto:gurchetansingh@chromium.org">gurchetansingh@chromium.org</a>></div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, May 18, 2018 at 6:01 AM Elie Tournier <<a href="mailto:tournier.elie@gmail.com">tournier.elie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Wrong ML. I add <<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a>><br>
<br>
On Fri, May 18, 2018 at 10:46:29AM +1000, Dave Airlie wrote:<br>
> From: Dave Airlie <<a href="mailto:airlied@redhat.com" target="_blank">airlied@redhat.com</a>><br>
> <br>
> The host side hasn't got support for this feature yet, so don't enable it<br>
> unless we get the caps from the host.<br>
> <br>
> This makes the texture buffer range piglit tests skip now.<br>
> <br>
> Fixes: fe0647df5a7 (virgl: add offset alignment values to to v2 caps struct)<br>
Acked-by: Elie Tournier <<a href="mailto:elie.tournier@collabora.com" target="_blank">elie.tournier@collabora.com</a>><br>
> ---<br>
>  src/gallium/drivers/virgl/virgl_winsys.h | 2 +-<br>
>  1 file changed, 1 insertion(+), 1 deletion(-)<br>
> <br>
> diff --git a/src/gallium/drivers/virgl/virgl_winsys.h b/src/gallium/drivers/virgl/virgl_winsys.h<br>
> index 99e98ad9c9c..690e610e199 100644<br>
> --- a/src/gallium/drivers/virgl/virgl_winsys.h<br>
> +++ b/src/gallium/drivers/virgl/virgl_winsys.h<br>
> @@ -132,7 +132,7 @@ static inline void virgl_ws_fill_new_caps_defaults(struct virgl_drm_caps *caps)<br>
>     caps->caps.v2.max_texel_offset = 7;<br>
>     caps->caps.v2.min_texture_gather_offset = -8;<br>
>     caps->caps.v2.max_texture_gather_offset = 7;<br>
> -   caps->caps.v2.texture_buffer_offset_alignment = 32;<br>
> +   caps->caps.v2.texture_buffer_offset_alignment = 0;<br>
>     caps->caps.v2.uniform_buffer_offset_alignment = 256;<br>
>  }<br>
>  #endif<br>
> -- <br>
> 2.14.3<br>
> <br>
> _______________________________________________<br>
> virglrenderer-devel mailing list<br>
> <a href="mailto:virglrenderer-devel@lists.freedesktop.org" target="_blank">virglrenderer-devel@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/virglrenderer-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/virglrenderer-devel</a><br>
_______________________________________________<br>
virglrenderer-devel mailing list<br>
<a href="mailto:virglrenderer-devel@lists.freedesktop.org" target="_blank">virglrenderer-devel@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/virglrenderer-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/virglrenderer-devel</a><br>
</blockquote></div>