[waffle] Getting started with Waffle and Piglit

[Chad Versace]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/29/2012 05:45 AM, Heikkila, Juha-pekka wrote:
> Hi,
> 
> I did check the comments you had on the patch I posted. I started some
> work to fix the issues but I don't yet have anything to post.
> 
> Couple of the issues were such where I was not thinking while coding and
> then there is the namespace, related classes and ANativeWindow I need to
> check they can be used thread safe.

I also need to check the thread-safety of the Wayland, CGL, X, and EGL calls
already present in Waffle. That is on my todo list.

Considering how many unknowns exist with respect to the thread-safety of these
platform library calls, I think we should proceed under the assumption that
all such platform calls are thread-safe. I don't want these unknowns to delay
Waffle's progress. And I think, at the beginning, that this decission will not
harm any Waffle users, since the only user is Piglit and it does not yet have
any multi-threaded tests.

After investigating the thread-safety of these platform calls, and only then,
do I think it's appropriate to decide to which degree Waffle should be
thread-safe and to begin introducing the necessary locking to achieve that
decsion.

However, despite working under the assumption for now that "all platform calls
are thread-safe", we should always try to keep thread-safe the overall design
and the data structures of Waffle itself.

> I will be away from keyboard for the following three weeks spending my
> summer vacation thus I will not post fixes during that time.

No problem. We can be very patient with the patch. I will be touching Waffle
very little in the next two weeks, because I've been asked to focus on a
high-priority multisample task.

Enjoy your vacation.

- -Chad

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJP7efsAAoJEAIvNt057x8irYQP/RlipFptZmbWC1zrSYOXD6PU
x76pv29uZUo+J4h+Dt0HS0PGErre4z+aaDJ6QyxwWA5asAqO7WYm3j3tnanOFjDh
coHbxEi43aOnfpO1sd5TdC5Y4AC6gmMqnV3GOP5OdjLSBZRiCS6suAYijN+/4Ry4
wEk2CWc9trr9quBgveWUN2b6/1JO8W1meONQA6yLpVshwXuNQ0rJ8KwPGQ1KTxfA
LCD3GX2oU6C4vM4hHat1daL5cXz8gEQV2Q/x3fAIpfBpwSseJvzANi1+8sJYINrv
fEDpu51fImGAaPdnS4IynahMH/wzoyXA9PnaHrFiClosju6zoYuQIs4oruxYjw6E
EYmivyR6mhAtJN4FSgZ6qJcIDR/ueGcPsbl1HkJCCGZgcn1TfQUQk5tXttlYFtzr
38yNlYBk0xa5PgG3EljzTuG0EcRJdGLksmOlRLb+uZB1bAwvlIobIDWALVKXyUAW
siaUJq3jJNEnDrSXzfifWKI/JX7C6P++NEdWhA78y+D/YZl3flHYiSIEovUcWiOJ
59eMcKxf6ss+oHBGXWgf8HJM4qrLbng6Oidkc/yZdxoXLytpyBddberhDCEnyCeK
9JfCYzpqdGl3BzI5lbCVYDuUMeyIH/fgkMS9OIMp/ZqIw4JW6vYvBTXtiZmsSf2f
vfLIhGvCXRa+5zVW90BI
=D7re
-----END PGP SIGNATURE-----