[waffle] [PATCH] core: Zero-initialize wcore_info struct.

[Chad Versace]

On 08/20/2013 08:55 AM, Paul Berry wrote:
> Without this, it's possible that the garbage memory returned by malloc
> will have wcore_info::is_init == true, causing wcore_tinfo_init() to
> skip initialization.  That in turn causes a likely segfault the first
> time wcore_info::error is accessed.
>
> Fixes piglit crashes introduced by commit 6fcbe52 ("cmake: Refactor
> compiler flags into new module").
>

Thanks. Committed to master.

> Note: I'm not exactly sure why the piglit crashes only started
> occurring with 6fcbe52.  My best guess is that the non-TLS code path
> has always had this bug, and the cmake refactor caused me to switch
> from building with TLS to building without TLS.
>
> If that's the case then it may be worth fixing as well :)

You're right. My build stopped using TLS too. I'm looking into that now.