[waffle] [PATCH] android: Fix createSurface compiler error

Tom Gall tom.gall at linaro.org
Thu Jan 24 07:27:24 PST 2013


Thanks! Please commit.

Reviewed-by: Tom Gall <tom.gall at linaro.org>

On Thu, Jan 24, 2013 at 7:00 AM,  <groleo at gmail.com> wrote:
> From: Adrian Marius Negreanu <adrian.m.negreanu at intel.com>
>
> it looks like createSurface changed signature:
>
> waffle/src/waffle/android/droid_surfaceflingerlink.cpp:113:36:
> error: no matching function for call to
> android::SurfaceComposerClient::createSurface(
>   android::String8, int, const uint32_t&, const uint32_t&, android::<anonymous enum>, int)
>
> candidate is:
> frameworks/native/include/gui/SurfaceComposerClient.h:80:24:
> android::sp<android::SurfaceControl> android::SurfaceComposerClient::createSurface(
>   const android::String8&, uint32_t, uint32 _t, android::PixelFormat, uint32_t)
>
> Signed-off-by: Adrian Marius Negreanu <adrian.m.negreanu at intel.com>
> ---
>  src/waffle/android/droid_surfaceflingerlink.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/waffle/android/droid_surfaceflingerlink.cpp b/src/waffle/android/droid_surfaceflingerlink.cpp
> index 7272c0d..5085c62 100644
> --- a/src/waffle/android/droid_surfaceflingerlink.cpp
> +++ b/src/waffle/android/droid_surfaceflingerlink.cpp
> @@ -108,7 +108,7 @@ droid_setup_surface(
>
>      pANWContainer->surface_control =
>              pSFContainer->composer_client->createSurface(
> -            String8("Waffle Surface"), 0,
> +            String8("Waffle Surface"),
>              droid_magic_surface_width, droid_magic_surface_height,
>              PIXEL_FORMAT_RGB_888, 0);
>
> --
> 1.8.0
>
> _______________________________________________
> waffle mailing list
> waffle at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/waffle



-- 
Regards,
Tom

"Where's the kaboom!? There was supposed to be an earth-shattering
kaboom!" Marvin Martian
Tech Lead, Graphics Working Group | Linaro.org │ Open source software
for ARM SoCs
w) tom.gall att linaro.org
h) tom_gall att mac.com


More information about the waffle mailing list